On Wed, Apr 28, 2021 at 04:43:46PM +0800, tiantao (H) wrote: > > 在 2021/4/28 7:44, Jarkko Sakkinen 写道: > > On Tue, Apr 20, 2021 at 11:10:45AM +0800, Tian Tao wrote: > > > Function returns 'void __iomem *' so use IOMEM_ERR_PTR for returning > > > an error. > > You should also tell why we want to to use IOMEM_ERR_PTR in the > > description. If it makes sense, then you should know why it makes > > sense. > > thank for review the code ,I'll send a v2 to update the commit message. > > This is to simplify the code, the definition of IOMEM_ERR_PTR is in > include/linux/io.h > > #define IOMEM_ERR_PTR(err) (__force void __iomem *)ERR_PTR(err) > > I'll send it to v2 and put the above sentence in the commit messge, what do > you think? I don't pre-ack patches. /Jarkko
