On Tue, Mar 23, 2021 at 07:51:53AM +0200, Paul Enuta wrote:
> Hi,
> it happens with 5.10.25-v7l (latest mainline in Raspberry PI OS) and
> in my test it started with 5.10.0-v7+.
> 5.4.83-v7+ was OK.
> Problems occur on fresh and clean installs with kernel versions above 5.10.
> This quick fix solves:
> --- tpm-chip.c.orig 2021-03-22 17:43:05.433433496 +0000
> +++ tpm-chip.c 2021-03-22 18:22:52.000000000 +0000
> @@ -101,6 +101,11 @@
> {
> int ret;
>
> + if (!chip->ops) {
> + pr_err("%s: Avoiding NULL ops pointer\n", __func__);
> + return -EIO;
> + }
> +
> tpm_clk_enable(chip);
>
> if (chip->locality == -1) {
>
Please try with the actual mainline. We don't care about RPi kernel.
> On Tue, Mar 23, 2021 at 4:09 AM Jarkko Sakkinen <jarkko@xxxxxxxxxx> wrote:
> >
> > On Mon, Mar 22, 2021 at 11:01:09PM +0200, Paul Enuta wrote:
> > > Dear all,
> > >
> > > As described in the issue here:
> > > https://github.com/raspberrypi/linux/issues/4228
> > > and here:
> > > https://www.raspberrypi.org/forums/viewtopic.php?f=75&t=303564&p=1817702#p1839351
> > > starting with kernel 5.10.XX we encounter a system hang with kernel
> > > panic at poweroff or reboot if we have dtoverlay=tpm-slb9670 loaded.
> > > Applying the patch proposed here:
> > > https://github.com/raspberrypi/linux/issues/4228#issuecomment-804081079
> > > and rebuilding the kernel solves the issue.
> > >
> > > Please review the issue and provide guidance finding the cause and solving.
> > >
> > > Kind regards,
> > > Paul Enuta
> >
> >
> > So does this happen with the latest mainline? Patched kernels are not our
> > concern.
> >
> >
> > /Jarkko
>
/Jarkko
