Hi Lakshmi, On Fri, 2020-11-13 at 11:22 -0800, Lakshmi Ramasubramanian wrote: > The function prototype for the functions defined in ima.c for powerpc > are given in the header file ima.h. But this header file is not > included in ima.c resulting in compilation errors such as given below. > > arch/powerpc/kexec/ima.c:56:5: error: no previous prototype for 'ima_get_kexec_buffer' [-Werror=missing-prototypes] > 56 | int ima_get_kexec_buffer(void **addr, size_t *size) > | ^~~~~~~~~~~~~~~~~~~~ > > The function parameters for remove_ima_buffer() and > arch_ima_add_kexec_buffer() are not described in the function header > resulting in warnings such as given below. > > arch/powerpc/kexec/ima.c:111: warning: Function parameter or member 'fdt' not described in 'remove_ima_buffer' > > Include ima.h in ima.c for powerpc. Describe the function parameters for > remove_ima_buffer() and arch_ima_add_kexec_buffer(). > > Co-developed-by: Prakhar Srivastava <prsriva@xxxxxxxxxxxxxxxxxxx> > Signed-off-by: Prakhar Srivastava <prsriva@xxxxxxxxxxxxxxxxxxx> > Signed-off-by: Lakshmi Ramasubramanian <nramas@xxxxxxxxxxxxxxxxxxx> thanks, Reviewed-by: Mimi Zohar <zohar@xxxxxxxxxxxxx>
