Hi Shuah, I love your patch! Perhaps something to improve: [auto build test WARNING on staging/staging-testing] [also build test WARNING on integrity/next-integrity char-misc/char-misc-testing usb/usb-testing linus/master v5.10-rc3 next-20201110] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Shuah-Khan/Introduce-seqnum_ops/20201111-035753 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git f4acd33c446b2ba97f1552a4da90050109d01ca7 config: sh-allmodconfig (attached as .config) compiler: sh4-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/4124aef613b0e30b7da08aaec750983854e1ca5a git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Shuah-Khan/Introduce-seqnum_ops/20201111-035753 git checkout 4124aef613b0e30b7da08aaec750983854e1ca5a # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): In file included from security/integrity/ima/ima_fs.c:25: security/integrity/ima/ima.h:178:18: error: field 'len' has incomplete type 178 | struct seqnum64 len; /* number of stored measurements in the list */ | ^~~ security/integrity/ima/ima.h:179:18: error: field 'violations' has incomplete type 179 | struct seqnum64 violations; | ^~~~~~~~~~ security/integrity/ima/ima_fs.c: In function 'ima_show_htable_value': security/integrity/ima/ima_fs.c:47:52: error: implicit declaration of function 'seqnum64_read'; did you mean 'seqnum32_read'? [-Werror=implicit-function-declaration] 47 | len = scnprintf(tmpbuf, sizeof(tmpbuf), "%lli\n", seqnum64_read(val)); | ^~~~~~~~~~~~~ | seqnum32_read >> security/integrity/ima/ima_fs.c:47:46: warning: format '%lli' expects argument of type 'long long int', but argument 4 has type 'int' [-Wformat=] 47 | len = scnprintf(tmpbuf, sizeof(tmpbuf), "%lli\n", seqnum64_read(val)); | ~~~^ ~~~~~~~~~~~~~~~~~~ | | | | | int | long long int | %i security/integrity/ima/ima_fs.c: In function 'ima_show_htable_violations': security/integrity/ima/ima_fs.c:56:1: error: control reaches end of non-void function [-Werror=return-type] 56 | } | ^ security/integrity/ima/ima_fs.c: In function 'ima_show_measurements_count': security/integrity/ima/ima_fs.c:69:1: error: control reaches end of non-void function [-Werror=return-type] 69 | } | ^ cc1: some warnings being treated as errors vim +47 security/integrity/ima/ima_fs.c 40 41 static ssize_t ima_show_htable_value(char __user *buf, size_t count, 42 loff_t *ppos, struct seqnum64 *val) 43 { 44 char tmpbuf[32]; /* greater than largest 'long' string value */ 45 ssize_t len; 46 > 47 len = scnprintf(tmpbuf, sizeof(tmpbuf), "%lli\n", seqnum64_read(val)); 48 return simple_read_from_buffer(buf, count, ppos, tmpbuf, len); 49 } 50 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
