On Tue, Nov 03, 2020 at 04:00:29PM -0700, Jerry Snitselaar wrote: > > Jarkko Sakkinen @ 2020-11-02 21:43 MST: > > > On Fri, Oct 30, 2020 at 09:11:30AM -0700, Jerry Snitselaar wrote: > >> > >> James Bottomley @ 2020-10-30 08:49 MST: > >> > >> > On Fri, 2020-10-30 at 14:43 +0200, Jarkko Sakkinen wrote: > >> > [...] > >> >> I tested this with: > >> >> > >> >> - > >> >> https://ark.intel.com/content/www/us/en/ark/products/84861/intel-nuc-kit-nuc5i5myhe.html > >> >> dTPM 1.2 > >> >> - > >> >> https://ark.intel.com/content/www/us/en/ark/products/74483/intel-nuc-kit-dc53427hye.html > >> >> dTPM 2.0 > >> >> > >> >> I did not get "TPM interrupt not working, polling instead" to klog. > >> >> But I neither see tpm0 in /proc/interrupts. What I'm doing wrong? > >> > > >> > That's usually what you get when ACPI specifies the interrupt isn't > >> > connected (we don't try to probe it). > >> > > >> > James > >> > >> That is the problem I've been running into. When I do find a system > >> with a tpm and using tpm_tis, it usually seems to not have the interrupt > >> connected. > >> > >> Should this commit have: > >> > >> Fixes: 570a36097f30 ("tpm: drop 'irq' from struct tpm_vendor_specific") > >> > >> That is where TPM_CHIP_FLAG_IRQ was added and not set for tpm_tis. > > > > Have you tested 4eea703caaac? > > > > /Jarkko > > Is that the right commit id? > > 4eea703caaac tpm: drop 'iobase' from struct tpm_vendor_specific | 2016-06-25 | (Christophe Ricard) Yeah. /Jarkko
