On Mon, Oct 19, 2020 at 12:11:44AM +0300, Jarkko Sakkinen wrote: > On Thu, Oct 15, 2020 at 02:44:30PM -0700, Jerry Snitselaar wrote: > > There is a misconfiguration in the bios of the gpio pin used for the > > interrupt in the T490s. When interrupts are enabled in the tpm_tis > > driver code this results in an interrupt storm. This was initially > > reported when we attempted to enable the interrupt code in the tpm_tis > > driver, which previously wasn't setting a flag to enable it. Due to > > the reports of the interrupt storm that code was reverted and we went back > > to polling instead of using interrupts. Now that we know the T490s problem > > is a firmware issue, add code to check if the system is a T490s and > > disable interrupts if that is the case. This will allow us to enable > > interrupts for everyone else. If the user has a fixed bios they can > > force the enabling of interrupts with tpm_tis.interrupts=1 on the > > kernel command line. > > > > Cc: jarkko@xxxxxxxxxx > > Cc: Peter Huewe <peterhuewe@xxxxxx> > > Cc: Jason Gunthorpe <jgg@xxxxxxxx> > > Cc: Hans de Goede <hdegoede@xxxxxxxxxx> > > Reviewed-by: James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> > > Signed-off-by: Jerry Snitselaar <jsnitsel@xxxxxxxxxx> > > Reviewed-by: Jarkko Sakkinen <jarkko@xxxxxxxxxx> > > I'll apply this and make it available in linux-next. Applied. Thank you. /Jarkko
