On Tue, Oct 13, 2020 at 08:15:36AM -0700, Jerry Snitselaar wrote: > > Jarkko Sakkinen @ 2020-10-12 18:17 MST: > > > On Thu, Oct 01, 2020 at 11:09:20AM -0700, James Bottomley wrote: > >> The current state of the TIS TPM is that interrupts have been globally > >> disabled by various changes. The problems we got reported the last > >> time they were enabled was interrupt storms. With my own TIS TPM, > >> I've found that this is caused because my TPM doesn't do legacy > >> cycles, The TIS spec (chapter 6.1 "Locality Usage Per Register") > >> requires any TIS TPM without legacy cycles not to act on any write to > >> an interrupt register unless the locality is enabled. This means if > >> an interrupt fires after we relinquish the locality, the TPM_EOI in > >> the interrupt routine is ineffective meaning the same interrupt > >> triggers over and over again. This problem also means we can have > >> trouble setting up interrupts on TIS TPMs because the current init > >> code does the setup before the locality is claimed for the first time. > >> > >> James > > > > You should consider expanding the audience. Jerry, once you have some > > bandwidth (no rush, does not land before rc2), it would be great that if > > you could try this. I'm emphasizing this just because of the > > intersection. I think it would also make senset to get tested-by from > > Nayna. > > I will run some tests on some other systems I have access to. As noted > in the other email I did a quick test with a t490s with an older bios > that exhibits the problem originally reported when Stefan's patch > enabled interrupts. Thank you. As said, I can make a pull request to rc2 or even rc3, if needed. /Jarkko
