Re: [integrity:next-integrity-testing 13/13] security/integrity/ima/ima_appraise.c:21:62: error: expected ')' before numeric constant

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2020-10-13 at 20:28 +0200, Ard Biesheuvel wrote:
> On Tue, 13 Oct 2020 at 20:09, kernel test robot <lkp@xxxxxxxxx> wrote:
> >
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/zohar/linux-integrity.git next-integrity-testing
> > head:   bfa46be051c194a941641c128f5e6f315f1ec232
> > commit: bfa46be051c194a941641c128f5e6f315f1ec232 [13/13] ima: defer arch_ima_get_secureboot() call to IMA init time
> > config: xtensa-allyesconfig (attached as .config)
> > compiler: xtensa-linux-gcc (GCC) 9.3.0
> > reproduce (this is a W=1 build):
> >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         # https://git.kernel.org/pub/scm/linux/kernel/git/zohar/linux-integrity.git/commit/?id=bfa46be051c194a941641c128f5e6f315f1ec232
> >         git remote add integrity https://git.kernel.org/pub/scm/linux/kernel/git/zohar/linux-integrity.git
> >         git fetch --no-tags integrity next-integrity-testing
> >         git checkout bfa46be051c194a941641c128f5e6f315f1ec232
> >         # save the attached .config to linux build tree
> >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=xtensa
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> >
> > All errors (new ones prefixed by >>):
> >
> > >> security/integrity/ima/ima_appraise.c:21:62: error: expected ')' before numeric constant
> >       21 | core_param(ima_appraise, ima_appraise_cmdline_default, charp, 0);
> >          |                                                              ^~
> >          |                                                              )
> >
> > vim +21 security/integrity/ima/ima_appraise.c
> >
> >     18
> >     19  #ifdef CONFIG_IMA_APPRAISE_BOOTPARAM
> >     20  static char *ima_appraise_cmdline_default __initdata;
> >   > 21  core_param(ima_appraise, ima_appraise_cmdline_default, charp, 0);
> >     22
> >
> 
> The error message is a bit misleading here, but this can be fixed by adding
> 
> #include <linux/module.h>
> 
> at the top. Let me know if I need to respin for this.

No, that's ok.  I'll just add it.

thanks!

Mimi





[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux Kernel]     [Linux Kernel Hardening]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux