On Thu, Oct 08, 2020 at 01:45:18PM +0200, Petr Vorel wrote: > Hi, > > > Create sysfs per hash groups with 24 PCR files in them one group, > > named pcr-<hash>, for each agile hash of the TPM. The files are > > plugged in to a PCR read function which is TPM version agnostic, so > > this works also for TPM 1.2 but the hash is only sha1 in that case. > > > Note: the macros used to create the hashes emit spurious checkpatch > > warnings. Do not try to "fix" them as checkpatch recommends, otherwise > > they'll break. > > > Signed-off-by: James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> > > Reviewed-by: Jerry Snitselaar <jsnitsel@xxxxxxxxxx> > > Tested-by: Thiago Jung Bauermann <bauerman@xxxxxxxxxxxxx> > > Reviewed-by: Petr Vorel <pvorel@xxxxxxx> > Tested-by: Petr Vorel <pvorel@xxxxxxx> > On both TPM 1.2 and TPM 2.0. > /sys/class/tpm/tpm0/pcr-sha*/* is exporting well on both. > James, thanks for implementing nice API! OK, great thank you. Unfortunately too late for v5.10 but without doubt going to v5.11. Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx> > BTW are all of these just TPM 1.2 specific? > /sys/class/tpm/tpm0/device/enabled > /sys/class/tpm/tpm0/device/pcrs > /sys/kernel/security/tpm0/binary_bios_measurements Yes. > Kind regards, > Petr Thanks a lot for your feedback, easier to judge given that you actually consume this :-) /Jarkko
