Hi Jarkko, > On Wed, Sep 30, 2020 at 07:53:14AM +0200, Petr Vorel wrote: > > Hi Jarkko, > > > Hi, is there something specific I should look at in this patch set? > > I'm sorry to bother you with LTP specific code. Can you have a quick look if I > > didn't overlook anything obvious in reading PCR files (read_pcr_tpm*())? > > I'm surprised that it's working on my TPM 2.0 which does not export > > /sys/kernel/security/tpm0/binary_bios_measurements (using evmctl). > Thank you, this was actually really important remark and reminder. > OK so I think James' patch is stuck because of me, i.e. > https://lore.kernel.org/linux-integrity/20200911114820.GB6877@xxxxxxxxxxxxxxx/ > I'm sorry about this. The final final conclusion is that the way it > exports PCRs is just fine. That's a great, thank you for going to upstream James' patch. James, thanks for implementing it! > Can you test this version? Sure, I'll test it next week. > https://patchwork.kernel.org/patch/11759729/ > I can then add reviewd-by and apply it and you don't have to do any sort > of stupid hacks. I'll need to keep these hacks for older kernels, but it's great that there is a better solution. Other thing: do you know anybody practically uses more TPM devices in single machine? I'm asking that I work with tpm0 in ima_tpm.sh, but maybe I should allow user to redefine it to choose different device (or even run tests for all available devices). Kind regards, Petr > /Jarkkko
