On Wed, Jul 22, 2020 at 08:57:39AM -0700, James Bottomley wrote:
> use macro magic to create sysfs per hash groups with 24 PCR files in
'Use'
Please, just say what the patch does in plain English and dust the magic
away.
> them one for each possible agile hash of the TPM. The files are
~~
I'd prefer a single space.
> plugged in to a read function which is TPM version agnostic, so this
> works also for TPM 1.2 although the hash is only sha1 in that case.
> For every hash the TPM supports, a group named pcr-<hash> is created
> and each of the PCR read files placed under it.
Yeah, the commit message is missing the statement what it does and goes
straight away rationalizing "macro magic".
> Signed-off-by: James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>
> Reviewed-by: Jerry Snitselaar <jsnitsel@xxxxxxxxxx>
/Jarkko
