Hi Mimi,
> - log_info("%s: verification failed: unknown keyid %x\n",
> - file, __be32_to_cpup(&keyid));
> + if (imaevm_params.verbose > LOG_INFO)
> + log_info("%s: verification failed: unknown keyid %x\n",
BTW, I was thinking to add more macros which would handle if
(imaevm_params.verbose > LOG_INFO), something like:
+#define log_dump_verbose(p, len) if (imaevm_params.verbose > LOG_INFO) do_dump(p, len, true)
+#define log_verbose(fmt, args...) if (imaevm_params.verbose > LOG_INFO) log_info(fmt, ##args)
But in the end I didn't post it, because:
1) imaevm_params.verbose is sometimes used for other purpose:
src/evmctl.c:
if (sigdump || imaevm_params.verbose >= LOG_INFO)
imaevm_hexdump(sig, len);
...
if (imaevm_params.verbose > LOG_INFO) {
log_info("%d ", entry->header.pcr);
log_dump_n(entry->header.digest, sizeof(entry->header.digest));
log_info(" %s %s", entry->name, algo);
log_dump_n(digest, digest_len);
log_info(" %s", path);
if (fbuf) {
log_info(" ");
log_dump_n(fbuf, fbuf_len);
}
}
...
if (imaevm_params.verbose <= LOG_INFO)
return;
2) code sometimes compares: imaevm_params.verbose >= LOG_INFO (i.e. >= vs >; is
that intentional?)
Kind regards,
Petr
