[Cc'ing Patrick Uiterwijk] On Wed, 2020-07-15 at 22:57 +0300, Vitaly Chikunov wrote: > Mimi, > > On Wed, Jul 15, 2020 at 03:34:26PM -0400, Mimi Zohar wrote: > > On Wed, 2020-07-15 at 15:37 +0200, Petr Vorel wrote: > > > Hi Mimi, > > > > > > > instead of checking in build time as it's runtime dependency. > > > > Also log when tsspcrread not found to make debugging easier. > > > > > > > We search for tsspcrread unless there is tss2-esys with Esys_PCR_Read(), > > > > thus pcr_none.c was dropped as unneeded. > > > > > > > file_exist(), tst_get_path() and MIN() taken from LTP project. > > > BTW these parts holds Cyril's copyright. If you ever add copyright to > > > src/utils.[ch], please add it there. > > > Copyright (C) 2010 Cyril Hrubis <chrubis@xxxxxxx> > > > > Are you Ok with the following? > > > > diff --git a/src/utils.c b/src/utils.c > > I don't remember me authoring anything in src/utils.c Thank you for catching that! The new file came from Patrick. > > index 416a88c6dbe4..a6ae08fa4d84 100644 > > --- a/src/utils.c > > +++ b/src/utils.c > > @@ -1,3 +1,10 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * utils: set of common functions > > + * > > + * Copyright (C) 2020 Vitaly Chikunov <vt@xxxxxxxxxxxx> Copyright (C) 2020 Patrick Uiterwijk <patrick@xxxxxxxxxxxxxx> > > + * Copyright (C) 2010 Cyril Hrubis <chrubis@xxxxxxx> > > + */ > > #include <stdint.h> > > #include <stdio.h> > > #include <stdlib.h>