On 7/15/20 4:18 AM, Petr Vorel wrote:
+++ b/testcases/kexec/utils.sh
@@ -0,0 +1,47 @@
+#!/bin/sh
+
+install() {
+ local arg="$1"
+
+ if [ ! -d "/etc/init.d" ]; then
+ mkdir /etc/init.d
+ fi
I'm not sure if tests like this are suitable for LTP.
Ideal LTP test is a normal test, which is able to run with runltp, cleanup after
itself and use LTP C or/and shell API. LTP is full of tests which needs special
handling and thus not being run, not sure if it's a good idea to introduce yet
another one.
Also test shouldn't not significantly modify SUT to make it unbootable, which
I'm not sure in this case. This is a big difference to kselftests which are
meant to help during kernel development which somehow expects some system
modifications (as you install your custom build kernel).
I wonder if using QEMU would help to implement this test while not touching SUT
(thus be able to run this test with runltp). If you miss something in LTP API
just let us know.
Using qemu is an interesting idea, but would be difficult to generalize.
I actually do agree with you that a test like this may not be
appropriate for
LTP since it's so separate and alien to the rest of the LTP suite.
I need to confirm internally before I make a decision here, but is there
a better place to put a test like this?
Thanks for your review,
Lachlan :)
