On Tue, Jun 23, 2020 at 12:59:33AM +0300, Jarkko Sakkinen wrote: > On Thu, Jun 18, 2020 at 04:43:38PM +0300, amirmizi6@xxxxxxxxx wrote: > > From: Amir Mizinski <amirmizi6@xxxxxxxxx> > > > > Added a retry mechanism on any protocol error. In addition, a retry is > > added in case of a data integrity issue in the I2C bus protocol. The check > > is performed after sending a command to the TPM and after receiving a > > response from the TPM. > > No chance to merge this without reasoning why on any protocol error we > should retry. It's not reasoned here. Unfotunately, with this premise I > cannot merge this. Additional remark: you should split the retry mechanism and callback addition to separate commits as they must be reasoned separately. See the section one in: https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html "If your changes produce a lot of deltas, you need to split them into individual patches which modify things in logical stages; see 3) Separate your changes. This will facilitate review by other kernel developers, very important if you want your patch accepted." /Jarkko
