Re: [PATCH] tpm_tis: extra chip->ops check on error path in tpm_tis_core_init

[Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx>]

On Tue, Jun 16, 2020 at 07:26:32PM -0700, Jerry Snitselaar wrote:
> On Sat Jun 13 20, Vasily Averin wrote:
> > Found by smatch:
> > drivers/char/tpm/tpm_tis_core.c:1088 tpm_tis_core_init() warn:
> > variable dereferenced before check 'chip->ops' (see line 979)
> > 
> > 'chip->ops' is assigned in the beginning of function
> > in tpmm_chip_alloc->tpm_chip_alloc
> > and is used before first possible goto to error path.
> > 
> > Signed-off-by: Vasily Averin <vvs@xxxxxxxxxxxxx>
> 
> Reviewed-by: Jerry Snitselaar <jsnitsel@xxxxxxxxxx>

Thanks, I added this to the commit.

/Jarkko