On Thu, 2020-05-14 at 14:26 +0300, Jarkko Sakkinen wrote: > On Tue, 2020-05-12 at 17:14 +0300, amirmizi6@xxxxxxxxx wrote: > > From: Amir Mizinski <amirmizi6@xxxxxxxxx> > > > > Only tpm_tis can use memory-mapped I/O, which is truly mapped into > > the kernel's memory space. Therefore, using ioread16/ioread32/iowrite32 > > turns into a straightforward pointer dereference. > > Every other driver requires more complicated operations to read more than > > one byte at a time and will just fall back to read_bytes/write_bytes. > > Therefore, move this common code out of tpm_tis_spi and into tpm_tis_core > > so that it is used automatically when low-level drivers do not implement > > the specialized methods. > > > > Co-developed-by: Alexander Steffen <Alexander.Steffen@xxxxxxxxxxxx> > > Signed-off-by: Alexander Steffen <Alexander.Steffen@xxxxxxxxxxxx> > > Signed-off-by: Amir Mizinski <amirmizi6@xxxxxxxxx> > > Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx> > > OK, so I applied this one: > > http://git.infradead.org/users/jjs/linux-tpmdd.git/commit/fa05dc792ea02043f3c21467cb4485a38ac19bdf > > I.e. no need to carry this one any more in the series. Sorry that > I haven't done this before (should have). Dropped it. Breaks the compilation: ld: drivers/char/tpm/tpm_tis_spi_cr50.o:(.rodata+0x10): undefined reference to `tpm_tis_spi_read16' ld: drivers/char/tpm/tpm_tis_spi_cr50.o:(.rodata+0x18): undefined reference to `tpm_tis_spi_read32' ld: drivers/char/tpm/tpm_tis_spi_cr50.o:(.rodata+0x20): undefined reference to `tpm_tis_spi_write32' Please fix this issue in the next version of the patch and remove my reviewed-by. I will have to re-review the patch. /Jarkko
