On Thu, Apr 16, 2020 at 11:54:33AM -0700, Omar Sandoval wrote: > On Thu, Apr 16, 2020 at 08:08:10PM +0300, Jarkko Sakkinen wrote: > > On Wed, Apr 15, 2020 at 03:45:22PM -0700, Omar Sandoval wrote: > > > From: Omar Sandoval <osandov@xxxxxx> > > > > > > We've encountered a particular model of STMicroelectronics TPM that > > > transiently returns a bad value in the status register. This causes the > > > kernel to believe that the TPM is ready to receive a command when it > > > actually isn't, which in turn causes the send to time out in > > > get_burstcount(). In testing, reading the status register one extra time > > > convinces the TPM to return a valid value. > > > > > > Signed-off-by: Omar Sandoval <osandov@xxxxxx> > > > > So what is the bad value? > > 0xff. Sorry, I thought it would be clear from the code and comment in > the patch itself. Would you prefer for me to repeat it in the commit > message? It is part of the problem description where as "bad value" does not have any particular meaning. /Jarkko
