> -----Original Message----- > From: linux-integrity-owner@xxxxxxxxxxxxxxx [mailto:linux-integrity- > owner@xxxxxxxxxxxxxxx] On Behalf Of Tianjia Zhang > Sent: Tuesday, April 14, 2020 1:42 PM > To: peterhuewe@xxxxxx; jarkko.sakkinen@xxxxxxxxxxxxxxx; jgg@xxxxxxxx; > arnd@xxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; zhang.jia@xxxxxxxxxxxxxxxxx > Cc: linux-integrity@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > tianjia.zhang@xxxxxxxxxxxxxxxxx > Subject: [PATCH] tpm: fix wrong return value in tpm_pcr_extend > > For the algorithm that does not match the bank, a positive > value EINVAL is returned here. I think this is a typo error. > It is necessary to return an error value. Yes, thanks. Reviewed-by: Roberto Sassu <roberto.sassu@xxxxxxxxxx> Roberto HUAWEI TECHNOLOGIES Duesseldorf GmbH, HRB 56063 Managing Director: Li Peng, Li Jian, Shi Yanli > Signed-off-by: Tianjia Zhang <tianjia.zhang@xxxxxxxxxxxxxxxxx> > --- > drivers/char/tpm/tpm-interface.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm- > interface.c > index a438b1206fcb..1621ce818705 100644 > --- a/drivers/char/tpm/tpm-interface.c > +++ b/drivers/char/tpm/tpm-interface.c > @@ -323,7 +323,7 @@ int tpm_pcr_extend(struct tpm_chip *chip, u32 > pcr_idx, > > for (i = 0; i < chip->nr_allocated_banks; i++) { > if (digests[i].alg_id != chip->allocated_banks[i].alg_id) { > - rc = EINVAL; > + rc = -EINVAL; > goto out; > } > } > -- > 2.17.1
