On Thu, Apr 09, 2020 at 11:10:44PM +0200, Hans de Goede wrote:
> Since commit dda8b2af395b ("tpm: Revert "tpm_tis_core: Set
> TPM_CHIP_FLAG_IRQ before probing for interrupts"") we no longer set
> the TPM_CHIP_FLAG_IRQ ever.
This all used to work..
> So the whole IRQ probing code is not useful, worse we rely on the
> IRQ-test path of tpm_tis_send() to call disable_interrupts() if
> interrupts do not work, but that path never gets entered because we
> never set the TPM_CHIP_FLAG_IRQ.
The IRQ probing code should be deleted.
> On some systems, e.g. the Lenovo X1 8th gen, the interrupt we try
> to use and never free creates an interrupt storm followed by
> an "irq XX: nobody cared" oops.
Is this related to probing?
Jason
