On 3/31/2020 8:13 AM, Jarkko Sakkinen wrote:
On Tue, Mar 31, 2020 at 02:32:03PM +0300, amirmizi6@xxxxxxxxx wrote:
From: Amir Mizinski <amirmizi6@xxxxxxxxx>
Using this function while read/write data resulted in aborted operation.
After investigating according to TCG TPM Profile (PTP) Specifications,
i found cancel should happen only if TPM_STS.commandReady bit is lit and
couldn't find a case when the current condition is valid.
Also only cmdReady bit need to be compared instead of the full lower status
register byte.
Signed-off-by: Amir Mizinski <amirmizi6@xxxxxxxxx>
We don't care about spec's. We care about hardware and not all hardware
follows specifications.
Please fix the exact thing you want to fix (and please provide a fixes
tag).
I edit the TPM main spec, not the PTP. As I discover TPMs that don't
meet the spec, or where the spec has changed over time, I add
informative comments to guide developers.
If you know of TPM hardware that does not meet the PTP specification,
let me know the specifics. I can bring it to the PTP work group and try
to get comments added.
I do not need to know the TPM vendor. That information would not go
into the specification anyway.
