Re: [PATCH v5 3/3] tpm: ibmvtpm: Add support for TPM 2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 3/3/20 3:11 PM, Jarkko Sakkinen wrote:
On Mon, Mar 02, 2020 at 11:21:27AM -0500, Stefan Berger wrote:
On 3/2/20 6:15 AM, Jarkko Sakkinen wrote:
On Thu, Feb 27, 2020 at 10:03:30PM -0500, Stefan Berger wrote:
From: Stefan Berger <stefanb@xxxxxxxxxxxxx>

Support TPM 2 in the IBM vTPM driver. The hypervisor tells us what
version of TPM is connected through the vio_device_id.
I'd prefer "TPM2" over "TPM 2".
Fixed.
In case a TPM 2 is found, we set the TPM_CHIP_FLAG_TPM2 flag
and get the command codes attributes table. The driver does
not need the timeouts and durations, though.
A TPM2 what? TPM2 is not a thing.

I don't know what you mean? Is it the word 'found' and it should be
'present' ? Otherwise a TPM2 is a 'thing' / object / device, at least to me.
TPM2 chip would be better. TPM2 can refer either to the protocol or to a
chip.

Let's call it 'device', which in this case is a virtual device rather than a 'virtual chip.'


   Stefan


/Jarkko





[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux Kernel]     [Linux Kernel Hardening]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux