On Mon, Feb 10, 2020 at 06:28:32PM +0200, amirmizi6@xxxxxxxxx wrote: > From: Amir Mizinski <amirmizi6@xxxxxxxxx> > > Only tpm_tis has a faster way to access multiple bytes at once, every other > driver will just fall back to read_bytes/write_bytes. Therefore, move this Describe exactly what you mean instead of "faster way" and "multiple bytes". > common code out of tpm_tis_spi into tpm_tis_core, so that it is > automatically used when low-level drivers do not implement the specialized > methods. > > This commit is based on previous work by Alexander Steffen. > > Signed-off-by: Amir Mizinski <amirmizi6@xxxxxxxxx> You are missing commas in the short summary message when you list bunch of things. We prefer "tpm:" instead of "char: tpm:" as the tag for this subsystem. You are also implying that this would be something global for the TPM driver whereas it is only scoped to tpm_tis: Rephrase it something like: "tpm: tpm_tis: Make 32-bit reads and writes optional" Please, first, take this away: " This commit is based on previous work by Alexander Steffen. Signed-off-by: Amir Mizinski <amirmizi6@xxxxxxxxx> " Then, replace it with: Co-developed-by: Alexander Steffen <Alexander.Steffen@xxxxxxxxxxxx> Signed-off-by: Alexander Steffen <Alexander.Steffen@xxxxxxxxxxxx> Signed-off-by: Amir Mizinski <amirmizi6@xxxxxxxxx> /Jarkko
