Re: [PATCH v2 2/2] tpm: tpm2_bios_measurements_next should increase position index

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/1/20 8:03 PM, Jarkko Sakkinen wrote:
> On Thu, Jan 30, 2020 at 01:23:21PM +0300, Vasily Averin wrote:
>> If seq_file .next function does not change position index,
>> read after non-zero lseek can generate unexpected output.
> 
> Is it unwanted or unexpected? Unexpected would be mean random
> output. I don't think that is the case. Please describe more
> throughly.

If .next function does not change position index, 
following .show function will repeat output related to current position index.

>> For /sys/kernel/security/tpm0/binary_bios_measurements:
>> 1) read after lseek beyond end of file generates whole last line.
>> 2) read after lseek to middle of last line generates
>> expected end of last line and unexpected whole last line once again.
>>
>> Cc: stable@xxxxxxxxxxxxxxx
>> Fixes: 1f4aace60b0e ("fs/seq_file.c: simplify seq_file iteration code ...")
>>
> No empty line here.
> 
>> https://bugzilla.kernel.org/show_bug.cgi?id=206283
> 
> "Link: https://bugzilla.kernel.org/show_bug.cgi?id=206283";
> 
> /Jarkko
> 



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux Kernel]     [Linux Kernel Hardening]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux