On Mon, 2020-01-06 at 17:08 -0800, James Bottomley wrote: > > Even if for good reasons, you should be explicit when you make an API > > change that is not backwards compatible. > > This change should be backwards compatible. I've got a set of TPMs, > one of which works both before and after and another which doesn't work > before but does after, so all it does is increase the set of TPMs that > work with the authorizations i.e. if the TPM worked before, it > continues to work after. > > I think what happens in the TPMs that work before is that they > explicily remove trailing zeros and ones that don't work before don't. > > Actually, the before form (20 hex bytes) still works in the after case > ... I'll make that clear in the commit message. OK, got it, thanks! Yeah, obviously would not hurt to be bit more explicit. /Jarkko
