On Mon, 2019-12-30 at 09:37 -0800, James Bottomley wrote: Again bad formatting in the short summary. > Modify the tpm2 key format blob output to export and import in the > ASN.1 form for tpm2 sealed object keys. For compatibility with prior > trusted keys, the importer will also accept two tpm2b quantities > representing the public and private parts of the key. However, the > export via keyctl pipe will only output the ASN.1 format. I think this is fair enough when it comes to backwards compatibility. What you should do with the earlier patch is to document in the commit message this framework for backwards compatibility. It is redundancy but makes the commit log easier to follow. E.g. tell in that commit message that ASN.1 loader will handle loading old blobs. > The benefit of the ASN.1 format is that it's a standard and thus the > exported key can be used by userspace tools. The format includes > policy specifications, thus it gets us out of having to construct > policy handles in userspace and the format includes the parent meaning > you don't have to keep passing it in each time. Please be explicit with the tools you are referring. Point out what you are using if there is variable number of choices. In high-level the code change itself looks good. /Jarkko
