On Thu, 2019-12-12 at 09:48 -0800, Tadeusz Struk wrote: > When an application sends TPM commands in NONBLOCKING mode > the driver holds chip->tpm_mutex returning from write(), > which triggers: "WARNING: lock held when returning to user space". > To fix this issue the driver needs to release the mutex before > returning and acquire it again in tpm_dev_async_work() before > sending the command. This is way better, thank you. I'll put this to my rc3 PR. > > Cc: stable@xxxxxxxxxxxxxxx > Fixes: 9e1b74a63f776 (tpm: add support for nonblocking operation) > Reported-by: Jeffrin Jose T <jeffrin@xxxxxxxxxxxxxxxxxxx> > Tested-by: Jeffrin Jose T <jeffrin@xxxxxxxxxxxxxxxxxxx> > Signed-off-by: Tadeusz Struk <tadeusz.struk@xxxxxxxxx> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx> /Jarkko
