Re: [PATCH v4 1/2] IMA: Define workqueue for early boot "key" measurements

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/16/2019 4:30 AM, Mimi Zohar wrote:

+
+		if (!list_empty(&ima_keys)) {
+			list_for_each_entry_safe(entry, tmp, &ima_keys, list)
+				list_move_tail(&entry->list, &temp_ima_keys);
+			process = true;
+		}
+	}
+
+	mutex_unlock(&ima_keys_mutex);
+
+	if (!process)
+		return;

The new changes - checking if the list is empty and this test - are
unnecessary, as you implied earlier.

Mimi

Do you want me to remove this check? I feel it is safer to have this check - use a local flag "process" to return if no keys were moved to the temp list. Would like to leave it as is - if you don't mind.

thanks,
 -lakshmi





[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux Kernel]     [Linux Kernel Hardening]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux