On Tue, Nov 12, 2019 at 08:28:57AM -0500, Stefan Berger wrote: > I set this flag for the TIS because it wasn't set anywhere else. > tpm_tis_send() wouldn't set the flag but go via the path: > > if (!(chip->flags & TPM_CHIP_FLAG_IRQ) || priv->irq_tested) > > return tpm_tis_send_main(chip, buf, len); Wondering why this isn't just "if (priv->irq_tested)"? Isn't that the whole point. The tail is the test part e.g. should be executed when IRQ testing is done. /Jarkko