On Mon, Oct 28, 2019 at 02:05:07PM -0700, Jerry Snitselaar wrote: > On Mon Oct 28 19, Jarkko Sakkinen wrote: > > On Fri, Oct 25, 2019 at 12:31:03PM -0700, Jerry Snitselaar wrote: > > > + return sprintf(buf, "%s\n", chip->flags & TPM_CHIP_FLAG_TPM2 > > > + ? "2.0" : "1.2"); > > > > This is not right. Should be either "1" or "2". > > > > /Jarkko > > Okay I will fix that up. Do we have a final decision on the file name, > major_version versus version_major? Well, I don't see how major_version would make any sense. It is not as future proof as version_major. Still waiting for Jason's feedback for this. /Jarkko
