On Thu, Oct 24, 2019 at 10:09:42PM +0300, Jarkko Sakkinen wrote:
> Why do you think that way?
>
> I mean the commit does not even have a fixes line. It already obviously
> implies that this kind of discussion is mandatory. Your reasoning in
> this discussion does make sense. The problem is really the commit
> message supplied.
>
> I'd guess something like this would be more appropriate:
>
> "
> platform_get_irq() calls dev_err() on an error. As the IRQ usage in the
> tpm_tis driver is optional, this is undesirable.
>
> Specifically this leads to this new false-positive error being logged:
> [ 5.135413] tpm_tis MSFT0101:00: IRQ index 0 not found
>
> This commit switches to platform_get_irq_optional(), which does not log
> an error, fixing this.
>
> Fixes: 7723f4c5ecdb ("driver core: platform: Add an error message to platform_get_irq*()"
> Cc: <stable@xxxxxxxxxxxxxxx> # 5.4.x
> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> "
This is much better, yes
Jason
