On 10/15/19 5:30 PM, Mimi Zohar wrote:
As per Documentation/process/submitting-patches.rst section "2) Describe your changes", please begin the patch description by describing the problem.
Will do.
This patch should be broken up even further.[1] In this case to simplify review, separate defining the new LSM hook from any IMA code. Different maintainers need to Ack/sign off on these patches. The new LSM hook patch, with a clear well written patch description, should be posted on the LSM mailing list as well.
Will do
+ +inline bool is_platform_trusted_keyring(struct key *keyring) +{ + #ifdef CONFIG_INTEGRITY_PLATFORM_KEYRING + return (keyring == platform_trusted_keys); + #else + return false; + #endif +}Why are these functions defined in a new LSM hook patch? Before posting a patch, please review the patch line by line, making sure that there isn't anything extraneous.
Since these are helper functions that will be used by IMA (which I will post shortly), I thought it is appropriate to include this.
Sorry about that - I'll move it out of this patch set. Will send an updated change today. thanks, -lakshmi
