On Fri, Oct 11, 2019 at 09:50:27AM +0200, Heiko Stübner wrote: > Am Montag, 7. Oktober 2019, 00:39:00 CEST schrieb Jarkko Sakkinen: > > On Fri, Sep 20, 2019 at 11:32:34AM -0700, Stephen Boyd wrote: > > > This patch series adds support for the H1 secure microcontroller > > > running cr50 firmware found on various recent Chromebooks. This driver > > > is necessary to boot into a ChromeOS userspace environment. It > > > implements support for several functions, including TPM-like > > > functionality over a SPI interface. > > > > > > The last time this was series sent looks to be [1]. I've looked over the > > > patches and review comments and tried to address any feedback that > > > Andrey didn't address (really minor things like newlines). I've reworked > > > the patches from the last version to layer on top of the existing TPM > > > TIS SPI implementation in tpm_tis_spi.c. Hopefully this is more > > > palatable than combining the two drivers together into one file. > > > > > > Please review so we can get the approach to supporting this device > > > sorted out. > > > > > > [1] https://lkml.kernel.org/r/1469757314-116169-1-git-send-email-apronin@xxxxxxxxxxxx > > [...] > > > OK, so, I put these to my master in hopes to get testing exposure. > > I think the changes are in great shape now. Thank you. > > on a rk3399-gru-bob it works nicely for me, so > Tested-by: Heiko Stuebner <heiko@xxxxxxxxx> Thank you! I updated my tree with your tag. Mind if I also add reviewed-by's? /Jarkko
