Re: [PATCH] selftest/trustedkeys: TPM 1.2 trusted keys test

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2019-09-15 at 16:52 -0400, Mimi Zohar wrote:
> On Fri, 2019-09-13 at 15:08 +0100, Jarkko Sakkinen wrote:
> > On Wed, Sep 11, 2019 at 08:00:40AM -0400, Mimi Zohar wrote:
> > > On Tue, 2019-09-10 at 19:24 -0400, Mimi Zohar wrote:
> > > > On Tue, 2019-09-10 at 19:18 -0400, Mimi Zohar wrote:
> > > > > Create, save and load trusted keys test
> > > > 
> > > > Creating trusted keys is failing with the following messages.  Any idea why?
> > > > 
> > > > [  147.014653] tpm tpm0: A TPM error (34) occurred attempting to a send a command
> > > > [  147.014678] trusted_key: srkseal failed (-1)
> > > > [  147.014687] trusted_key: key_seal failed (-1)
> > > 
> > > This is a regression, that needs to be resolved.  The test works on
> > > kernels prior to 5.1.
> > 
> > It breaks on 5.2?
> 
> No, the regression is in 5.1.
> 
> > 
> > Can you bisect the failing commit?
> 
> git bisect start -- drivers/char/tpm/
> git bisect bad
> git bisect good v5.0 
> 
> # first bad commit: [412eb585587a1dc43c9622db79de9663b6c4c238] tpm:
> use tpm_buf in tpm_transmit_cmd() as the IO parameter

In tpm_send(), setting buf.data directly to cmd, instead of calling
tpm_buf_init() fixes the problem.

Mimi





[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux Kernel]     [Linux Kernel Hardening]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux