Am Dienstag, 13. August 2019, 00:36:16 CEST schrieb Stephen Boyd: > This patch series adds support for the the H1 secure microcontroller > running cr50 firmware found on various recent Chromebooks. This driver > is necessary to boot into a ChromeOS userspace environment. It > implements support for several functions, including TPM-like > functionality over a SPI interface. > > The last time this was series sent looks to be [1]. I've looked over the > patches and review comments and tried to address any feedback that > Andrey didn't address (really minor things like newlines). I've reworked > the patches from the last version to layer on top of the existing TPM > TIS SPI implementation in tpm_tis_spi.c. Hopefully this is more > palatable than combining the two drivers together into one file. > > [1] https://lkml.kernel.org/r/1469757314-116169-1-git-send-email-apronin@xxxxxxxxxxxx Gave this a spin on a rk3399-gru-scarlet and it seems to have worked fine and tpm2-tools was happy talking to it, so Tested-by: Heiko Stuebner <heiko@xxxxxxxxx> >From looking through the patches everything also looks nice and peachy but my tpm-insights are limited so I don't really feel comfortable with a RB. Heiko