On Thu, 2019-08-08 at 14:45 +0300, Dan Carpenter wrote:
> On Thu, Aug 08, 2019 at 07:17:22AM -0400, Mimi Zohar wrote:
> > On Thu, 2019-08-08 at 13:33 +0300, Dan Carpenter wrote:
> > > This code frees "hdr" and then dereferences it on the next line to get
> > > the error code.
> > >
> > > Fixes: 39b07096364a ("ima: Implement support for module-style appended signatures")
> > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> >
> > Thanks, Dan. Julia already reported this. Thiago posted a patch last
> > night. Just getting to it now. Can I add your Reviewed-by or Tested-
> > by?
>
> I haven't seen the other patch so Reviewed-by seems like the wrong
> thing. I don't really need any sort of credit. I'm just going through
> my backlog of warnings from being out of office. Perhaps Reported-by?
That works. FYI, your solution and Thiago's are exactly the same.[1]
Mimi
[1] https://lore.kernel.org/linux-integrity/8736ico5ax.fsf@morokweng.localdomain/T/#u
