On Thu, 8 Aug 2019 at 02:03, Matthew Garrett <mjg59@xxxxxxxxxx> wrote:
>
> On Wed, Aug 7, 2019 at 2:59 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
> >
> > Fix get_efi_config_table using the wrong structs when booting a
> > 64 bit kernel on 32 bit firmware.
> >
> > Cc: Matthew Garrett <mjg59@xxxxxxxxxx>
> > Cc: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>
> > Cc: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx>
> > Fixes: 82d736ac56d7 ("Abstract out support for locating an EFI config table")
> > Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
>
> Acked-By: Matthew Garrett <mjg59@xxxxxxxxxx>
>
Thanks for fixing this, Hans.
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>
> Good catch. I think fixing this is preferable to reverting - the
> duplicate events are visible to userland, so there's a risk that apps
> will end up depending on them if there's a release that behaves that
> way.
Agreed, I will send this out as a fix.
> Presumably mixed mode isn't a thing on ARM?
Nope. I should have realised this when we made this routine generic,
but I failed to spot it. ARM is either strictly 32-bit or strictly
64-bit.
