On Thu, Jul 11, 2019 at 11:08:58PM +0300, Jarkko Sakkinen wrote: > On Fri, Jul 05, 2019 at 04:47:44PM -0400, Sasha Levin wrote: > > Changes from v7: > > > > - Address Jarkko's comments. > > > > Sasha Levin (2): > > fTPM: firmware TPM running in TEE > > fTPM: add documentation for ftpm driver > > > > Documentation/security/tpm/index.rst | 1 + > > Documentation/security/tpm/tpm_ftpm_tee.rst | 27 ++ > > drivers/char/tpm/Kconfig | 5 + > > drivers/char/tpm/Makefile | 1 + > > drivers/char/tpm/tpm_ftpm_tee.c | 350 ++++++++++++++++++++ > > drivers/char/tpm/tpm_ftpm_tee.h | 40 +++ > > 6 files changed, 424 insertions(+) > > create mode 100644 Documentation/security/tpm/tpm_ftpm_tee.rst > > create mode 100644 drivers/char/tpm/tpm_ftpm_tee.c > > create mode 100644 drivers/char/tpm/tpm_ftpm_tee.h > > > > -- > > 2.20.1 > > > > I applied the patches now. Appreciate a lot the patience with these. > Thank you. Hi, can you possibly fix these: 005-tpm-tpm_ftpm_tee-A-driver-for-firmware-TPM-running-i.patch --------------------------------------------------------------- WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line) #10: https://www.microsoft.com/en-us/research/publication/ftpm-software-implementation-tpm-chip/ . WARNING: Non-standard signature: Co-authored-by: #18: Co-authored-by: Sasha Levin <sashal@xxxxxxxxxx> WARNING: prefer 'help' over '---help---' for new help texts #39: FILE: drivers/char/tpm/Kconfig:167: +config TCG_FTPM_TEE WARNING: please write a paragraph that describes the config symbol fully #39: FILE: drivers/char/tpm/Kconfig:167: +config TCG_FTPM_TEE WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #57: new file mode 100644 WARNING: please, no space before tabs #102: FILE: drivers/char/tpm/tpm_ftpm_tee.c:41: + * ^IIn case of success the number of bytes received.$ WARNING: please, no space before tabs #131: FILE: drivers/char/tpm/tpm_ftpm_tee.c:70: + * ^IIn case of success, returns 0.$ WARNING: please, no space before tabs #276: FILE: drivers/char/tpm/tpm_ftpm_tee.c:215: + * ^IOn success, 0. On failure, -errno.$ WARNING: please, no space before tabs #366: FILE: drivers/char/tpm/tpm_ftpm_tee.c:305: + * ^I0 always.$ ERROR: code indent should use tabs where possible #387: FILE: drivers/char/tpm/tpm_ftpm_tee.c:326: + /* memory allocated with devm_kzalloc() is freed automatically */$ WARNING: DT compatible string "microsoft,ftpm" appears un-documented -- check ./Documentation/devicetree/bindings/ #393: FILE: drivers/char/tpm/tpm_ftpm_tee.c:332: + { .compatible = "microsoft,ftpm" }, WARNING: DT compatible string vendor "microsoft" appears un-documented -- check ./Documentation/devicetree/bindings/vendor-prefixes.yaml #393: FILE: drivers/char/tpm/tpm_ftpm_tee.c:332: + { .compatible = "microsoft,ftpm" }, total: 1 errors, 11 warnings, 405 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. NOTE: Whitespace errors detected. You may wish to use scripts/cleanpatch or scripts/cleanfile I temporarily dropped the patches but can apply them once the issues are fixed. /Jarkko
