Re: [RFC PATCH] ima-evm-utils: Add some tests for evmctl

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Bruno,

On Thu, Jul 25, 2019 at 06:58:43PM -0300, Bruno E. O. Meneguele wrote:
> On Thu, Jul 25, 2019 at 09:18:55AM +0300, Vitaly Chikunov wrote:
> > Run `make check' to execute the tests.
> > Currently only ima_hash, ima_sign (v2), and ima_verify are tested.
> > 
> > Signed-off-by: Vitaly Chikunov <vt@xxxxxxxxxxxx>
> > ---
> >  Makefile.am           |   2 +-
> >  configure.ac          |   1 +
> >  tests/Makefile.am     |  14 ++++
> >  tests/functions       | 135 ++++++++++++++++++++++++++++++++++++
> >  tests/gen-keys.sh     |  75 ++++++++++++++++++++
> >  tests/ima_hash.test   |  84 +++++++++++++++++++++++
> >  tests/ima_sign.test   | 186 ++++++++++++++++++++++++++++++++++++++++++++++++++
> >  tests/ima_verify.test |  79 +++++++++++++++++++++
> >  8 files changed, 575 insertions(+), 1 deletion(-)
> >  create mode 100644 tests/Makefile.am
> >  create mode 100755 tests/functions
> >  create mode 100755 tests/gen-keys.sh
> >  create mode 100755 tests/ima_hash.test
> >  create mode 100755 tests/ima_sign.test
> >  create mode 100755 tests/ima_verify.test
> > 
> > diff --git a/tests/Makefile.am b/tests/Makefile.am
> > new file mode 100644
> > index 0000000..8c6256c
> > --- /dev/null
> > +++ b/tests/Makefile.am
> > @@ -0,0 +1,14 @@
> > +check_SCRIPTS =
> > +TESTS = $(check_SCRIPTS)
> > +
> > +check_SCRIPTS += ima_hash.test ima_verify.test ima_sign.test
> > +
> > +# ima_verify depends on results of ima_hash
> > +ima_verify.log: ima_sign.log
> 
> Small nit: comment and code don't match, ima_hash vs ima_sign :). 
> 
> Maybe:
> 
> -# ima_verify depends on results of ima_hash
> +# ima_verify depends on results of ima_sign

Oh, yes. Thanks!




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux Kernel]     [Linux Kernel Hardening]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux