Mimi, On Thu, Jul 25, 2019 at 10:46:31AM -0400, Mimi Zohar wrote: > On Thu, 2019-07-25 at 09:18 +0300, Vitaly Chikunov wrote: > > Run `make check' to execute the tests. > > Currently only ima_hash, ima_sign (v2), and ima_verify are tested. > > > > Signed-off-by: Vitaly Chikunov <vt@xxxxxxxxxxxx> > > Nice! As much as I would like to include this patch in this release, > let's hold off and add it to the next release. You may include it if you wish, this should work good as is (over my latest patches). > Reviewing shorter patches is a lot easier, at least for me. Could you > break this patch up? Perhaps by defining the tests separately, and > then adding the autotools support to run the test afterwards? This is just tests, so they don't alter any other code, don't produce user visible features, and don't complicate anything. Each file inside of the patch could be understood separately.
