Mimi, On Wed, Jul 24, 2019 at 07:24:20PM -0400, Mimi Zohar wrote: > On Wed, 2019-07-24 at 23:42 +0300, Vitaly Chikunov wrote: > > Prefix `dump', `do_dump', and `params' with `ima_' to avoid colliding > > with other global symbols. > > The package is named ima-evm-utils, the tool is named evmctl, and now > we're prefixing the global symbols with "ima". Some of the functions, > like dump(), are used by both "ima" and "evm". Aiming for some sort > of consistency, maybe it should be prefixed with "ima_evm", not just > "ima_"? Just ima_ is OK with me. EVM could be thought as IMA extension. Or we can use evm_ like in evmctl. Or imaevm_ (without underscore, like in libimaevm or imaevm.h). > dump() should never have been named just "dump". It should have at > least been named "hexdump". > > > `params' is prefixed with a #define trick to avoid change in half > > hundred places. > > Perhaps separate this change from the other change? I agree to Bruno E. O. Meneguele it's better to actually rename `params' like other functions instead of redefining. Then all renames can go in one commit? Thanks,
