On Fri, Jul 12, 2019 at 12:41:58PM +0000, Safford, David (GE Global Research, US) wrote: > > > The issue is that the CRB region is mapped into a region marked as ACPI NVS. > > drivers/acpi/nvs.c claims this region and as a result a resource conflict is > > generated. Since Windows is clearly fine with other drivers using ACPI NVS > > regions, the correct fix involves figuring out a way to either share these > > resources or allow tpm_crb to reclaim the region from the NVS driver. Note > > that the NVS driver's behaviour is to save and restore NVS regions over > > suspend/resume, so simply forcibly allocating the resource will result in two > > separate codepaths touching the region on resume - this seems like a bad > > outcome. I wonder if the CRB in the nvs actually needs to be save/restored in AMD's implementation? Sounds like the answer is to have TPM CRB somehow detect NVS and acquire the resource from it, while somehow sequencing suspend/resume properly. Jason
