On Fri, 2019-06-14 at 04:54 +0300, Vitaly Chikunov wrote: > Convert sign_v2 and related to using more generic EVP_PKEY API instead > of RSA API. This enables more signatures to work out of the box. Please elaborate on "enables more signatures to work out of the box", perhaps with example(s). I like simple stories, where everything is laid out. Think of a patch set as a simple story, not a mystery, explaining how you go from point A to point B. Each patch in the series explains the next step. The changes in cmd_import() are nice, straight forward, and easy to read. Other than the "calc_keyid_v2()" change from passing an RSA key to pkey key" dependency, this could be a separate patch. Please see if you could further break this patch up to simplify review. Mimi
