Hi Vitaly, On Tue, 2019-05-28 at 19:31 -0400, Mimi Zohar wrote: > On Wed, 2019-05-29 at 01:46 +0300, Vitaly Chikunov wrote: > > I already tried to leave RSA handling as is for v1 signatures, because > > they are RSA specific anyway. > > > > Also, I tried to leave most (external) API the same, except > > calc_keyid_v2 which now gets EVP_PKEY instead of RSA. Internally, > > find_keyid now returns EVP_PKEY too. > > > > read_pub_key now extracts RSA from EVP_PKEY from read_pub_pkey. > > Right. So why couldn't the first patch define read_pub_pkey(), but > only call it from read_pub_key(). Then subsequent patches could call > read_pub_pkey() directly. > > > > > And calc_keyid_v2 now works internally slightly differently (and > > generally) to handle all possible key types. > > > > Also, I run some tests with ASan. Releasing a new version of ima-evm-utils is way over due. I'd really like to release a new version of ima-evm-utils soon. Are you planning on breaking this patch up? Mimi
