Hi Matthew, I love your patch! Yet something to improve: [auto build test ERROR on integrity/next-integrity] [also build test ERROR on v5.1 next-20190517] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Matthew-Garrett/IMA-Support-asking-the-VFS-for-a-file-hash/20190518-150531 base: https://git.kernel.org/pub/scm/linux/kernel/git/zohar/linux-integrity.git next-integrity config: arm-allmodconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.2.0 make.cross ARCH=arm If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): In file included from drivers/crypto/ux500/hash/hash_core.c:39:0: >> drivers/crypto/ux500/hash/hash_alg.h:272:6: error: nested redefinition of 'enum hash_algo' enum hash_algo { ^~~~~~~~~ >> drivers/crypto/ux500/hash/hash_alg.h:272:6: error: redeclaration of 'enum hash_algo' In file included from include/linux/fs.h:46:0, from include/linux/huge_mm.h:8, from include/linux/mm.h:527, from include/linux/scatterlist.h:8, from include/linux/dmaengine.h:24, from drivers/crypto/ux500/hash/hash_core.c:29: include/uapi/linux/hash_info.h:17:6: note: originally defined here enum hash_algo { ^~~~~~~~~ In file included from drivers/crypto/ux500/hash/hash_core.c:39:0: >> drivers/crypto/ux500/hash/hash_alg.h:273:2: error: redeclaration of enumerator 'HASH_ALGO_SHA1' HASH_ALGO_SHA1 = 0x0, ^~~~~~~~~~~~~~ In file included from include/linux/fs.h:46:0, from include/linux/huge_mm.h:8, from include/linux/mm.h:527, from include/linux/scatterlist.h:8, from include/linux/dmaengine.h:24, from drivers/crypto/ux500/hash/hash_core.c:29: include/uapi/linux/hash_info.h:20:2: note: previous definition of 'HASH_ALGO_SHA1' was here HASH_ALGO_SHA1, ^~~~~~~~~~~~~~ In file included from drivers/crypto/ux500/hash/hash_core.c:39:0: >> drivers/crypto/ux500/hash/hash_alg.h:274:2: error: redeclaration of enumerator 'HASH_ALGO_SHA256' HASH_ALGO_SHA256 = 0x1 ^~~~~~~~~~~~~~~~ In file included from include/linux/fs.h:46:0, from include/linux/huge_mm.h:8, from include/linux/mm.h:527, from include/linux/scatterlist.h:8, from include/linux/dmaengine.h:24, from drivers/crypto/ux500/hash/hash_core.c:29: include/uapi/linux/hash_info.h:22:2: note: previous definition of 'HASH_ALGO_SHA256' was here HASH_ALGO_SHA256, ^~~~~~~~~~~~~~~~ vim +272 drivers/crypto/ux500/hash/hash_alg.h 8a63b199 Andreas Westin 2012-04-30 266 8a63b199 Andreas Westin 2012-04-30 267 /** 8a63b199 Andreas Westin 2012-04-30 268 * enum hash_algo - Enumeration for selecting between SHA1 or SHA2 algorithm. 8a63b199 Andreas Westin 2012-04-30 269 * @HASH_ALGO_SHA1: Indicates that SHA1 is used. 8a63b199 Andreas Westin 2012-04-30 270 * @HASH_ALGO_SHA2: Indicates that SHA2 (SHA256) is used. 8a63b199 Andreas Westin 2012-04-30 271 */ 8a63b199 Andreas Westin 2012-04-30 @272 enum hash_algo { 8a63b199 Andreas Westin 2012-04-30 @273 HASH_ALGO_SHA1 = 0x0, 8a63b199 Andreas Westin 2012-04-30 @274 HASH_ALGO_SHA256 = 0x1 8a63b199 Andreas Westin 2012-04-30 275 }; 8a63b199 Andreas Westin 2012-04-30 276 :::::: The code at line 272 was first introduced by commit :::::: 8a63b1994c500d4825ee73dc71502deffe5b135b crypto: ux500 - Add driver for HASH hardware :::::: TO: Andreas Westin <andreas.westin@xxxxxxxxxxxxxx> :::::: CC: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
