Hi Mimi, > > But what is strange to me is that it continues to execute second line. return 1 [2] > > should cause ROD() to quit with TBROK [3]. > > Maybe that ROD in test1() should be replaced EXPECT_PASS. > With just the first patch of Ignaz's path set [1] and the TPM 2.0 test > [2], there aren't any errors. Without [1], it's now failing with the > correct name. I'm now seeing: I guess, that justifies [1] to be merged into kernel. > evm_overlay 1 TINFO: $TMPDIR is on tmpfs => run on loop device > evm_overlay 1 TINFO: Formatting /dev/loop0 with ext3 extra opts='' > evm_overlay 1 TINFO: overwrite file in overlay > tst_rod: Failed to open 'mntpoint/merged/foo1.txt' for writing: Permission denied > evm_overlay 1 TFAIL: echo overlay > mntpoint/merged/foo1.txt failed unexpectedly That still does not explain, why test doesn't exit before this last line. I'll have a closer look into it. But as I wrote, I'll make these changes: diff --git testcases/kernel/security/integrity/ima/tests/evm_overlay.sh testcases/kernel/security/integrity/ima/tests/evm_overlay.sh index 08ec1ea37..1d05b9e1c 100755 --- testcases/kernel/security/integrity/ima/tests/evm_overlay.sh +++ testcases/kernel/security/integrity/ima/tests/evm_overlay.sh @@ -40,7 +40,7 @@ test1() local file="foo1.txt" tst_res TINFO "overwrite file in overlay" - ROD echo lower \> $lower/$file + EXPECT_PASS echo lower \> $lower/$file EXPECT_PASS echo overlay \> $merged/$file } @@ -49,7 +49,7 @@ test2() local file="foo2.txt" tst_res TINFO "append file in overlay" - ROD echo lower \> $lower/$file + EXPECT_PASS echo lower \> $lower/$file EXPECT_PASS echo overlay \>\> $merged/$file } --- If it's ok for you and it's a valid test do you give an ack? Kind regards, Petr > Mimi > [1] https://www.spinics.net/lists/linux-integrity/msg05926.html > [2] https://lore.kernel.org/linux-integrity/1558041162.3971.2.camel@xxxxxxxxxxxxx/T/#u
