On Tue, Apr 02, 2019 at 01:56:43PM -0700, Stephen Hemminger wrote: > On Tue, 2 Apr 2019 12:33:16 -0700 > "Sasha Levin" <sashal@xxxxxxxxxx> wrote: > > > +/* > > + * ftpm_tee_tpm_op_recv retrieve fTPM response. > > + * @param: chip, the tpm_chip description as specified in > > driver/char/tpm/tpm.h. > > + * @param: buf, the buffer to store data. > > + * @param: count, the number of bytes to read. > > + * @return: In case of success the number of bytes received. > > + * In other case, a < 0 value describing the issue. > > + */ > > You are using a docbook style comment but it doesn't start with > docbook prefix. > > /** > * ftpm_tee_tpm_op_recv retrieve fTPM response. > * > * @param: chip, the tpm_chip description as specified in driver/char/tpm/tpm.h. > * @param: buf, the buffer to store data. > * @param: count, the number of bytes to read. > * @return: In case of success the number of bytes received. > * In other case, a < 0 value describing the issue. > */ This is different commenting style that we use on anything else under drivers/char/tpm. /Jarkko
