On Mon, Mar 11, 2019 at 9:55 AM Mimi Zohar <zohar@xxxxxxxxxxxxx> wrote: > > On Fri, 2019-03-08 at 09:51 -0800, Matthew Garrett wrote: > > Hm. And this only happens on certain firmware versions? If something's > > stepping on boot_params then we have bigger problems. > > I was seeing this problem before and after updating the system > firmware on my laptop last summer. If updating the firmware had > resolved the problem, I wouldn't have included this patch. Ah, sorry, when you said that you saw this with older firmware I thought that meant that newer firmware fixed it. What machine are you testing on?