Hi Mimi, > Define, update and move get_secureboot_mode() to a common file for use > by other tests. > Signed-off-by: Mimi Zohar <zohar@xxxxxxxxxxxxx> Reviewed-by: Petr Vorel <pvorel@xxxxxxx> ... > ifeq ($(ARCH),x86) > TEST_PROGS := test_kexec_load.sh > +TEST_FILES := common_lib.sh In case there might be some common library for whole selftest, I'd name this ima_lib.sh. (even it won't be in the same directory it might be better for readability). > include ../lib.mk > diff --git a/tools/testing/selftests/ima/common_lib.sh b/tools/testing/selftests/ima/common_lib.sh > new file mode 100755 > index 000000000000..5583ea74c14e > --- /dev/null > +++ b/tools/testing/selftests/ima/common_lib.sh > @@ -0,0 +1,24 @@ > +#!/bin/sh > +# SPDX-License-Identifier: GPL-2.0-or-later I'm sorry, that was me who advised GPL v2+ instead of GPL v2 only :). ... Kind regards, Petr