On Tue, Feb 19, 2019 at 09:34:56AM -0700, Jason Gunthorpe wrote: > > - Your real name is formatted incorrectly. It should be like "Yue Haibig" > > as shown in [1]. > > - If there is no actual regression, this change is useless. > > Clarity of the code is a laudible goal - not everything is about > fixing bugs or adding features. > > It is much easier to write the code properly than to try and prove > that event_size can not exceed INT_MAX. I think it is actually a regression in 4d23cc323cdb. Should carry a fixes tag. I did not quite undersand what commit message was saying. What it should would just """ tpm: Fix the type of the return value in calc_tpm2_event_size() calc_tpm2_event_size() has an invalid signature because it returns a 'size_t' where as its signature says that it returns 'int'. """ Should be also Cc'd to linux-security-module and have cc to stable. /Jarkko
